Skip to content

Reject request_user_input outside Plan/Pair#9955

Merged
charley-oai merged 4 commits intomainfrom
reject-request-user-input-outside-plan-and-pair
Jan 27, 2026
Merged

Reject request_user_input outside Plan/Pair#9955
charley-oai merged 4 commits intomainfrom
reject-request-user-input-outside-plan-and-pair

Conversation

@charley-oai
Copy link
Collaborator

@charley-oai charley-oai commented Jan 27, 2026

Context

Previous work in #9560 only rejected
request_user_input in Execute and Custom modes. Since then, additional modes
(e.g., Code) were added, so the guard should be mode-agnostic.

What changed

  • Switch the handler to an allowlist: only Plan and PairProgramming are allowed
  • Return the same error for any other mode (including Code)
  • Add a Code-mode rejection test alongside the existing Execute/Custom tests

Why

This prevents request_user_input from being used in modes where it is not
intended, even as new modes are introduced.

@charley-oai charley-oai marked this pull request as ready for review January 27, 2026 00:55
@charley-oai charley-oai enabled auto-merge (squash) January 27, 2026 01:01
@charley-oai charley-oai disabled auto-merge January 27, 2026 01:12
@charley-oai charley-oai merged commit 47aa1f3 into main Jan 27, 2026
29 of 31 checks passed
@charley-oai charley-oai deleted the reject-request-user-input-outside-plan-and-pair branch January 27, 2026 01:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants