-
Notifications
You must be signed in to change notification settings - Fork 125
Rewrite openColours()
#456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jack-davison
wants to merge
13
commits into
main
Choose a base branch
from
colorManagement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into colorManagement # Conflicts: # DESCRIPTION
Collaborator
Author
|
Hue is fixed. I have also:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Ideas for new features for openair
utilities 🛠
Openair data utilities, e.g., timeAverage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a rewrite of
openColours()that does three main things:Reversing Palettes
openColours()gainsdirectionin line with other colour packages like viridis/RColorBrewer/etc. Whendirectionis-1, you get a reversed palette.If you provide a scheme with a
-at the front, e.g.,"-Dark", this reversesdirection. This is to make it more convenient to use in otheropenairfunctions - e.g.,Streamlining Palette Behaviour
Formerly there were sequential palettes, diverging palettes, qualitative palettes, brewer palettes, hue, greyscale, and a few others. This PR recategorizes everything as either diverging/sequential or qualitative. This has a few benefits:
It is easier to add new palettes, because they will slot into one or the other category.
We can delete
RColorBrewer.R- the simplified setup fits everything in one file.All palettes will behave consistently to one another. The clearest example of this is the interpolation of qualitative palettes, which only occurred for the brewer palettes but not for other qualitative palettes. Now all qualitative palettes will interpolate, with warnings given if interpolation is occurring.
Managing Schemes through an R Object
openSchemes, which lists all of schemes available inopenColours().