[Store] Fix serializer backward compat: accept legacy 4-element Replica format#4
Open
stmatengss wants to merge 1 commit intohemist/cxl-level-storefrom
Open
[Store] Fix serializer backward compat: accept legacy 4-element Replica format#4stmatengss wants to merge 1 commit intohemist/cxl-level-storefrom
stmatengss wants to merge 1 commit intohemist/cxl-level-storefrom
Conversation
…ca format The new tiered storage feature added a storage_level field to the Replica msgpack format, bumping the array size from 4 to 5. Existing snapshots and persisted replicas that were serialized with the old 4-element format would fail deserialization with a hard error. Accept both sizes: when size==4 (legacy), default storage_level to RAM and use payload_index=3; when size==5 (new), read storage_level and use payload_index=4. This preserves full read compatibility with pre-upgrade data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The new
storage_levelfield in tiered storage bumped the Replica msgpack array from 4 to 5 elements. The deserializer strictly requires size == 5, so existing snapshots/persisted replicas fail with:Fix
Accept both sizes in
deserialize:storage_level = StorageLevel::RAM,payload_index = 3storage_levelfromarray_items[3],payload_index = 4Serialization always writes 5 elements. Read path handles both formats for upgrade compatibility.
Impact
StorageLevel::RAM(correct default)