[Store] Replace LOG(FATAL) with LOG(ERROR) for missing MC_CXL_DEV_SIZE#6
Open
stmatengss wants to merge 1 commit intohemist/cxl-level-storefrom
Open
[Store] Replace LOG(FATAL) with LOG(ERROR) for missing MC_CXL_DEV_SIZE#6stmatengss wants to merge 1 commit intohemist/cxl-level-storefrom
stmatengss wants to merge 1 commit intohemist/cxl-level-storefrom
Conversation
Two code paths in mp_setup_internal and setup_internal called LOG(FATAL) when the MC_CXL_DEV_SIZE environment variable was not set. LOG(FATAL) terminates the process unconditionally — inappropriate for a user configuration error that can be reported gracefully. Replace both LOG(FATAL) calls with LOG(ERROR) so the error is returned via the existing tl::unexpected(ErrorCode::INVALID_PARAMS) path without crashing the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two locations in
real_client.cppcallLOG(FATAL)whenMC_CXL_DEV_SIZEis not set:A missing env var is a user configuration error and should not crash the process.
Fix
Replace both
LOG(FATAL)calls withLOG(ERROR). Thereturn tl::unexpected(ErrorCode::INVALID_PARAMS)that follows then executes correctly as a graceful error return.Impact
MC_CXL_DEV_SIZEnow returnsINVALID_PARAMSinstead of crashing