[Store] Remove unreachable INVALID_BATCH_ID check after freeBatchID#7
Open
stmatengss wants to merge 1 commit intohemist/cxl-level-storefrom
Open
[Store] Remove unreachable INVALID_BATCH_ID check after freeBatchID#7stmatengss wants to merge 1 commit intohemist/cxl-level-storefrom
stmatengss wants to merge 1 commit intohemist/cxl-level-storefrom
Conversation
In submitTransfer and mp_submitTransfer, batch_id is validated once at function entry. On submission failure the batch is freed and the function returns immediately. A second INVALID_BATCH_ID guard placed after that error path is unreachable dead code and should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
submitTransferandmp_submitTransfer, after submission failure:batch_idis validated at function entry and cannot becomeINVALID_BATCH_IDbetween that guard and this check. The duplicate guard after the error-return path is never reached.Fix
Remove both unreachable
INVALID_BATCH_IDguards (one insubmitTransfer, one inmp_submitTransfer).Impact