Change model from_dict from staticmethod to classmethod #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CC @dbanty |
Contributor
|
LGTM assuming the checks pass - I or @dbanty need to fix the CI actions so that they run on PRs |
Collaborator
Author
|
Hi @dbanty, should I add you as a reviewer? For some reason it looks like the Reviewers section is disabled for me, not sure if I'm missing something:
|
Collaborator
|
@forest-benchling no need, I've got this on my list to review soon. Thanks for checking in though 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215.
This allows
from_dictto be inherited and overridden by subclasses. I couldn't think of any scenarios where this would be a breaking change, unless someone was relying on incorrect subclass inheritance.The only relevant changes are in
model.pyi. The rest of the files are from regenerating the e2e tests.