update squat analysis metrics and squat type detection#25
Merged
carmichaelong merged 2 commits intodevfrom Jun 10, 2024
Merged
Conversation
antoinefalisse
approved these changes
Jun 10, 2024
| 'x_axis': 'time', | ||
| 'y_axis': y_axes} | ||
| 'y_axis': y_axes, | ||
| 'squat_type': squat_type} |
Contributor
There was a problem hiding this comment.
Are you planning to change the dashboard to include this info?
Contributor
Author
There was a problem hiding this comment.
yes, i was planning on adding the detected type and seeing if sam would like it. otherwise, can leave it off for now and add it later if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@antoinefalisse updates to squat analysis on dev