squat_analysis: add body transforms dictionary#26
Merged
carmichaelong merged 1 commit intodevfrom Jun 10, 2024
Merged
Conversation
antoinefalisse
approved these changes
Jun 10, 2024
Contributor
antoinefalisse
left a comment
antoinefalisse
left a comment
There was a problem hiding this comment.
if not used for the other analyses, no need to update. Ideally we soon implement something to avoid duplicated scripts, but fine for now I guess. Thanks
Contributor
Author
|
Thanks @antoinefalisse! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding body transforms to get trunk lean for squats. Not sure if this should only update the
utilsKinematics.pyfile for squats, or if it's OK for this to be different than the one used in other analysis folders.