Added view to search sessions (by uuid and name).#250
Merged
AlbertoCasasOrtiz merged 1 commit intodevfrom Sep 19, 2025
Merged
Conversation
carmichaelong
requested changes
Aug 9, 2025
Contributor
carmichaelong
left a comment
There was a problem hiding this comment.
(cross posting this with the viewer PR) Search functionality worked, but a few issues to address:
- [viewer] The search box just says "Enter text", so users don't know that it's searching Session ID or Session Name
- [viewer] Once a search is done, I could only get back to the list of sessions by refreshing the page
- [viewer] Maybe could be nice if the "Submit" button wasn't as large as the other buttons? Might need to play around with this to figure out what looks good.
- [api] When trying to test the new button delays when recording, the New Session page gave a blank QR code. I could get past this when I merged
maininto the local branch, but for some reason the cameras could not connect to the session. I did notice that it looks likedevbranch is a little behindmainbranch here, and the api was calling thedevDB, so maybe there was a mismatch there? I haven't dug in further.
Member
Author
|
WIP:
The problem with the QR and camera connection is an old one, it's been happening for a while, that is why we mostly test on deployed versions on dev when we have to do a full capture testing. It could be good knowing if someone was able to fix this or if there is any other approach for testing that does not involve having to deploy into dev. Regarding dev being behind main, I guess that could be problematic in the future. We should update dev with changes in main. |
carmichaelong
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with opencap-org/opencap-viewer#436, as they depend on each other.