Conversation
suhlrich
left a comment
suhlrich
left a comment
There was a problem hiding this comment.
I tested kinematics and am testing a simulation. Let me know if you have questions wrt. the review comments. We just have to be careful to not break anything existing.
| pController.addActuator(newActuator) | ||
| # Attach the function to the controller. | ||
| pController.prescribeControlForActuator(0,constFxn) | ||
| pController.prescribeControlForActuator(newActuator.getName(),constFxn) |
There was a problem hiding this comment.
why do we need this? Are we computing joint reactions during STS? And what is wrong with calling 0 index?
| pController.setName(coordName + '_controller') | ||
| pController.addActuator(newActuator) | ||
| # Attach the function to the controller. | ||
| pController.prescribeControlForActuator(0,constFxn) |
|
|
||
| return (risingTimes, risingTimesDelayedStart, | ||
| risingSittingTimesDelayedStartPeriodicEnd) | ||
| # %% Segment sts |
There was a problem hiding this comment.
I think we want to leave the old segmenter alone as it is used in example_kinetics.py. Should we create a different segmenter or have you tested the example_kinetics code also?
| if motion_type == 'squats': | ||
| times_window = segment_squats(pathMotionFile, visualize=True) | ||
| elif motion_type == 'sit_to_stand': | ||
| _, _, times_window = segment_STS(pathMotionFile, visualize=True) |
There was a problem hiding this comment.
concern changing the segmenter for compatibility with other codes. I commented on the utilsProcessing file
|
|
||
| return angular_position_df | ||
|
|
||
| def get_body_angular_velocity(self, body_names=None, lowpass_cutoff_frequency=-1, expressed_in='body'): |
There was a problem hiding this comment.
is this left alone from before? In the review, it looks like we overwrite the get angular velocity with get orientation. Just want to make sure we don't change functions that are used elsewhere
2 participants
Sit-to-stand analysis scripts built in the style of gait_analysis.py, including optional kinetics.