Conversation
|
Hi @priya-tik |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1235/2025-11-10_16-14-56/ . |
ppettit
left a comment
There was a problem hiding this comment.
This helps with #1230 a little. It only requests /admin-ng/event/new/metadata once each time you click "create event", but now it looks like nothing is happening for several seconds while it loads. Closing the dialog also takes a couple of seconds.
metadata.fix.mp4
Also for opening an existing event metadata there are still 2 requests
metadata.fix.existing.mp4
It also looks like there are a bunch of unrelated changes in this PR.
|
on further testing I don't think this PR has an effect on #1230 at all. @priya-tik did you comment on the correct issue? |
|
@ppettit, Thanks for the feedback! You're right — this looks like a separate issue. My PR focuses on reducing the amount of unnecessary series data fetched from /admin-ng/event/{id}/metadata, but it doesn’t address the number of times the endpoint is called. I agree that repeated calls on open and close are a performance concern — I can look into that next as a follow-up task. |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
8b3f6e9 to
8f72174
Compare
Arnei
left a comment
There was a problem hiding this comment.
Does very significantly reduce the payload when sending updated event or series metadata to the backend. Code looks generally good and from my testing nothing else seems to break.
Mostly nitpicks below.
|
While you're latest commit addressed some of the style issues, it also applied style changes to a bunch of unrelated code. It would be nice if you could avoid that. |
|
This pull request has conflicts ☹ |
Arnei
left a comment
There was a problem hiding this comment.
Fixed the merge conflicts and my outstanding nitpicks myself. As they were minor, I am fine with merging this now. Should probably be squash-merged.
Refactored the "transformMetadataForUpdate" function to clean the metadata payload and ensure only the essential fields (id and value) are included in the request.
This change reduces the size of the payload and ensures it aligns with the backend's expected structure.