Series and events permissions override enhancement by ferishili · Pull Request #1295 · opencast/opencast-admin-interface

ferishili · 2025-05-19T11:58:58Z

This PR fixes #1290,

It introduces the optional offering of the button for the "overwrite of the events" when saving the series acl based on the config: admin.series.acl.event.update.mode as to being optional or empty to offer both buttons!
The button label and hint also got slightly more meaningful texts.

NOTE: At the time of creating this PR there is a commit/PR missing from develop (default) which makes the user and system perm separation, hence the permission dialogs are broken! So, please use stable.opencast.org in order to test!

… optional modal button

github-actions · 2025-05-19T12:00:07Z

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1295

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1295

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

github-actions · 2025-05-19T12:00:39Z

This pull request is deployed at test.admin-interface.opencast.org/1295/2026-01-19_16-12-35/ .
It might take a few minutes for it to become available.

Arnei

The configuration key admin.series.acl.event.update.mode seems to be missing in the backend. At least I could not find it. If it should exist, could you add it?

Arnei · 2025-05-21T11:56:51Z

src/components/events/partials/ModalTabsAndPages/SeriesDetailsAccessTab.tsx


+	const orgProperties = useAppSelector(state => getOrgProperties(state));
+
+	const overrideEnabled = (orgProperties['admin.series.acl.event.update.mode'] || 'optional').toLowerCase() === 'optional';


Aren't there supposed to be three modes, always, never and optional? Can that really be represented with a boolean?

You are right!
in this place to check and offer the button if it is optional is correct.
what is missing is to make sure that never & always are also in the play!

ferishili · 2025-05-22T06:28:25Z

The configuration key admin.series.acl.event.update.mode seems to be missing in the backend. At least I could not find it. If it should exist, could you add it?

It is under etc/org.opencastproject.organization-mh_default_org.cfg but by default commented out and set to optional!

Arnei · 2025-05-22T07:12:15Z

The configuration key admin.series.acl.event.update.mode seems to be missing in the backend. At least I could not find it. If it should exist, could you add it?

It is under etc/org.opencastproject.organization-mh_default_org.cfg but by default commented out and set to optional!

Sorry for troubling you, but could you point out the line in the file? I'm really not seeing it in https://github.com/opencast/opencast/blob/r/17.x/etc/org.opencastproject.organization-mh_default_org.cfg

ferishili · 2025-05-22T07:35:23Z

Sorry for troubling you, but could you point out the line in the file? I'm really not seeing it in https://github.com/opencast/opencast/blob/r/17.x/etc/org.opencastproject.organization-mh_default_org.cfg

No worries, it seems that it is missing in 17.x but it is there in 16.x!

https://github.com/opencast/opencast/blob/0fea543a1a8ada9e9017758e66bcbdf2513363c4/etc/org.opencastproject.organization-mh_default_org.cfg#L341C1-L342C1

However, the documentation for 17.x says it is still effectively there: https://docs.opencast.org/r/17.x/admin/#configuration/acl/#updating-series-permissions

[UPDATE]: @Arnei, I found the patch that removed the settings, it appears to me that this setting is removed considering it is related to old admin-ui which shouldn't!
PS: fun fact! Both removing commit and requesting to add it back came from Lars 😆

Arnei · 2025-05-22T07:50:18Z

No worries, it seems that it is missing in 17.x but it is there in 16.x!

https://github.com/opencast/opencast/blob/0fea543a1a8ada9e9017758e66bcbdf2513363c4/etc/org.opencastproject.organization-mh_default_org.cfg#L341C1-L342C1

However, the documentation for 17.x says it is still effectively there: https://docs.opencast.org/r/17.x/admin/#configuration/acl/#updating-series-permissions

[UPDATE]: @Arnei, I found the patch that removed the settings, it appears to me that this setting is removed considering it is related to old admin-ui which shouldn't! PS: fun fact! Both removing commit and requesting to add it back came from Lars 😆

:D Then would you do Lars the favor of adding it back to 17.x, just like it was in 16.x?

github-actions · 2025-05-24T13:23:30Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2025-06-18T09:11:07Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

snoesberger · 2025-06-18T15:24:15Z

Thanks for this PR @ferishili.

I did test this PR with our test environment where we have merge mode "actions" configured.

Setting prop.admin.series.acl.event.update.mode=never now hides the "Save series and overwrite event permissions" button and changing series permissions doesn't override the event ACLs.

If I configure prop.admin.series.acl.event.update.mode=optional and use the "Save series and overwrite event permissions" button, the existing event ACL is removed and replaced by the new series ACL. The "Save series permission" button only changes the series ACL. This works as expected

However, the behaviour of prop.admin.series.acl.event.update.mode=always does not appear to be as described in the documentation.

always: When modifying series permissions, automatically remove all permission rules specific to single episodes
belonging to the series. This enforces every episode has the rules of the series in effect as soon as they
are changed.

In our test environment, "always" and "never" behave exactly the same. As I understand it, when changing the series ACLs, the event ACLs should be removed and replaced with the new series ACLs. This is equivalent to the "Save series and overwrite event permissions" button with the prop.admin.series.acl.event.update.mode=optional configuration.

… optional modal button

Arnei · 2025-07-24T08:31:47Z

Rebased this onto r/17.x, as this is "fixing" a feature introduced with r/17.x (which was main at the time).

gregorydlogan · 2025-09-23T21:32:50Z

I'm seeing wonky behaviour locally which I can't reproduce with legacy.opencast.org:

Screencast.from.2025-09-23.15-28-21.mp4

This happens every time you modify the permissions for an unsaved role. So at the end of the video, if I went back and modified ROLE_ADMIN's permissions everything would work fine. If, however, I added a different role then it would reset the new role's dropdown to "Select or create a role" every time I change the permission - either adding, or removing it.

gregorydlogan · 2025-12-05T20:23:01Z

Given that 17.x is pretty much EOL at this point, should this get either punted forward to 18, or refiled when it's ready?

…min-interface into issue-1290

mtneug · 2026-01-18T15:09:13Z

src/i18n/org/opencastproject/adminui/languages/lang-en_US.json

+						"DETAILS": "Details",
+						"REPLACE_EVENT_ACLS": "Save series and overwrite event permissions",
+						"REPLACE_EVENT_ACLS_HINT": "Save the series permissions and overwrite the permissions for all events in this series.",
+						"SAVE_SERIES_ACL_ONLY": "Save series permission",


Is adding new keys allowed in release branches (docs say "modify existing translation keys").

This is not yet final!
I only rebased to 18.x and fixed the conflicts!

Regarding this, I would guess this would be the answer: #1295 (comment)

However, I would ask your feedback on this, @Arnei

ferishili · 2026-01-19T16:05:23Z

I'm seeing wonky behaviour locally which I can't reproduce with legacy.opencast.org

I went deep and tried to fix this in this PR, even though it's not directly related to the original issue. It should be handled in a separate issue, since it will likely take more time than I initially expected.

The root cause is the use of filtered policies combined with .map, which breaks the reactivity of the Formik values. As a result, the policies value for each element is no longer reactive and ends up applying its own isolated state to the object.

Arnei

This seems to work fine and code looks fine too.

I agree with Farbod that the issue Greg found is unrelated to this pull request and as such should be solved separately.

Now all we need to decide on is which branch this should go into.

KatrinIhler · 2026-01-20T16:00:54Z

Discussed this in the Dev Meeting, we would be okay with making an exception this time, but final decision is up to @jduehring and @dennis531

make sure the overwriting events perms is offered by the configs with…

d2a7003

… optional modal button

ferishili self-assigned this May 19, 2025

ferishili added priority:critical Unless this is fixed, we will not use the new admin ui type:enhancement New feature or request type:usability Improves the UX labels May 19, 2025

ferishili requested a review from Arnei May 19, 2025 11:59

Arnei requested changes May 21, 2025

View reviewed changes

github-actions bot added status:conflicts and removed status:conflicts labels May 24, 2025

github-actions bot added the status:conflicts label Jun 18, 2025

make sure the overwriting events perms is offered by the configs with…

934cc9f

… optional modal button

Arnei force-pushed the issue-1290 branch from d2a7003 to 934cc9f Compare July 24, 2025 08:30

Arnei changed the base branch from develop to r/17.x July 24, 2025 08:31

github-actions bot removed the status:conflicts label Jul 24, 2025

Merge branch 'issue-1290' of https://github.com/ferishili/opencast-ad…

67cca77

…min-interface into issue-1290

ferishili changed the base branch from r/17.x to r/18.x January 16, 2026 10:49

Merge branch 'r/18.x' into issue-1290

12acc83

mtneug reviewed Jan 18, 2026

View reviewed changes

apply always mode

3874582

ferishili requested a review from Arnei January 20, 2026 08:02

Arnei reviewed Jan 20, 2026

View reviewed changes

jduehring merged commit 07b3975 into opencast:r/18.x Jan 29, 2026
7 checks passed


		const orgProperties = useAppSelector(state => getOrgProperties(state));

		const overrideEnabled = (orgProperties['admin.series.acl.event.update.mode'] \|\| 'optional').toLowerCase() === 'optional';

Conversation

ferishili commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Arnei left a comment

Choose a reason for hiding this comment

Uh oh!

Arnei May 21, 2025

Choose a reason for hiding this comment

Uh oh!

ferishili May 22, 2025

Choose a reason for hiding this comment

Uh oh!

ferishili commented May 22, 2025

Uh oh!

Arnei commented May 22, 2025

Uh oh!

ferishili commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Arnei commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 24, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

snoesberger commented Jun 18, 2025

Uh oh!

Arnei commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gregorydlogan commented Sep 23, 2025

Uh oh!

gregorydlogan commented Dec 5, 2025

Uh oh!

mtneug Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

ferishili Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ferishili Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

ferishili commented Jan 19, 2026

Uh oh!

Arnei left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KatrinIhler commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ferishili commented May 19, 2025 •

edited

Loading

github-actions bot commented May 19, 2025 •

edited

Loading

ferishili commented May 22, 2025 •

edited

Loading

Arnei commented May 22, 2025 •

edited

Loading

Arnei commented Jul 24, 2025 •

edited

Loading

ferishili Jan 18, 2026 •

edited

Loading

Arnei left a comment •

edited

Loading