Skip to content

fix /Scheduling: Multiple event scheduling nitpicks #1077#1398

Merged
Arnei merged 4 commits intoopencast:developfrom
EnsiyehE:feature/event-scheduling-nitpicks-1077
Nov 13, 2025
Merged

fix /Scheduling: Multiple event scheduling nitpicks #1077#1398
Arnei merged 4 commits intoopencast:developfrom
EnsiyehE:feature/event-scheduling-nitpicks-1077

Conversation

@EnsiyehE
Copy link
Contributor

I have thoroughly reviewed the issues listed in #1077 and implemented fixes addressing each point mentioned. This PR aims to improve the user experience and correctness of the multiple event scheduling feature by resolving all identified nitpicks.

Changes include:

Please review and let me know if there are any questions or further adjustments needed.

@github-actions
Copy link
Contributor

Hi @EnsiyehE
Thank you for contributing to the Opencast Admin UI.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@github-actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1398

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1398

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@gregorydlogan gregorydlogan added type:bug Something isn't working type:usability Improves the UX labels Aug 12, 2025
@Arnei
Copy link
Member

Arnei commented Nov 11, 2025

My testing observations so far (Note that I merged the current state of develop into this for my testing, as otherwise the datepickers were broken for me):

  • I can still schedule events in the past by setting the start date in the past and the end date in the future. That should not be possible I think?
  • If no day of the week is in the date range, the error "The repeat days must be within the scheduled date range." is displayed. I think this what Scheduling: Multiple event scheduling nitpicks #1077 wanted, so that works 👍 . Maybe change the error message to "At least one repeat day must be within the scheduled date range" to more precisely describe the error condition to the user?
  • The "+1 day" message appears even if the end time is not on the next day, which should not happen. It seems the "+1 day" message appears if the duration is greater than an hour?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

This pull request is deployed at test.admin-interface.opencast.org/1398/2025-11-13_09-12-26/ .
It might take a few minutes for it to become available.

@EnsiyehE
Copy link
Contributor Author

My testing observations so far (Note that I merged the current state of develop into this for my testing, as otherwise the datepickers were broken for me):

Done the same now , update the local develop first and then this branch

  • I can still schedule events in the past by setting the start date in the past and the end date in the future. That should not be possible I think?
    fixed , you can not scheduale something in the past for both multiple or single ( it was not part of this task )
  • If no day of the week is in the date range, the error "The repeat days must be within the scheduled date range." is displayed. I think this what Scheduling: Multiple event scheduling nitpicks #1077 wanted, so that works 👍 . Maybe change the error message to "At least one repeat day must be within the scheduled date range" to more precisely describe the error condition to the user?

it is changed to the same sentence you have suggested

  • The "+1 day" message appears even if the end time is not on the next day, which should not happen. It seems the "+1 day" message appears if the duration is greater than an hour?

Now you can test it as before. After a duration that exactly leads to the next calendar day — for example, starting at 12 noon and lasting 12 hours — it should show +1 day. It should not show +1 day for durations like 11 hours and 55 minutes. This applies to both single and multiple event scheduling.

thanks
bests
Ensiyeh

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed. Works as expected and looks good to me 👍

@Arnei Arnei merged commit 7aa6a6d into opencast:develop Nov 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working type:usability Improves the UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants