Skip to content

Go to first page when changing filters via Stats#1477

Merged
gregorydlogan merged 4 commits intoopencast:r/17.xfrom
ciegler:stats-filter-first-page
Nov 24, 2025
Merged

Go to first page when changing filters via Stats#1477
gregorydlogan merged 4 commits intoopencast:r/17.xfrom
ciegler:stats-filter-first-page

Conversation

@ciegler
Copy link
Contributor

@ciegler ciegler commented Nov 12, 2025

Currently the Admin UI does not reset the offset and the page number when changing filters via the Stats bar.

With this the offset and the page number is set to 0 when a filter is changed via the Stats bar, without reloading all events as goToPage(0) would do.

@github-actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1477

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1477

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ciegler ciegler added the type:bug Something isn't working label Nov 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

This pull request is deployed at test.admin-interface.opencast.org/1477/2025-11-24_11-33-36/ .
It might take a few minutes for it to become available.

@gregorydlogan
Copy link
Member

This should probably be targeted earlier. In discussion at the dev meeting, this should go to 17.x.

@ciegler ciegler changed the base branch from develop to r/17.x November 19, 2025 08:48
@ciegler ciegler changed the base branch from r/17.x to develop November 19, 2025 08:49
ciegler and others added 2 commits November 19, 2025 11:02
Set the offset and page number to 0 when changing filters via the Stats
Bar without reloading all events.
@github-actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@ciegler ciegler changed the base branch from develop to r/17.x November 19, 2025 10:03
@ciegler
Copy link
Contributor Author

ciegler commented Nov 19, 2025

I rebased my branch to r/17.x and changed the PR to target the branch r/17.x.
This was my fist time changing the PR target branch, so I hope that these were the right steps to do.

@marwyg
Copy link
Member

marwyg commented Nov 24, 2025

I encountered this problem while testing something different. Found your PR and tested it. Seems to work 👍

@gregorydlogan gregorydlogan self-assigned this Nov 24, 2025
@gregorydlogan gregorydlogan merged commit e42ce1e into opencast:r/17.x Nov 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants