Remove useEffect hook validation from create modals#1486
Merged
gregorydlogan merged 1 commit intoopencast:r/19.xfrom Jan 23, 2026
Merged
Remove useEffect hook validation from create modals#1486gregorydlogan merged 1 commit intoopencast:r/19.xfrom
gregorydlogan merged 1 commit intoopencast:r/19.xfrom
Conversation
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
This hook would call upon the formik validation when the user switched to a different tab in the create modal. This is pointless because A. validation will automatically have been called by formik before then and B. this hook would only trigger after the tab has changed, which would be too late anyway.
a32df9a to
8d15b36
Compare
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1486/2025-12-18_14-54-04/ . |
gregorydlogan
approved these changes
Jan 23, 2026
gregorydlogan
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hook would call upon the formik validation when the user switched to a different tab in the create modal. This is pointless because A. validation will automatically have been called by formik before then and B. this hook would only trigger after the tab has changed, which would be too late anyway.