feat: add --terminal flag to control clientCapabilities.terminal#155
feat: add --terminal flag to control clientCapabilities.terminal#155DMQ wants to merge 2 commits intoopenclaw:mainfrom
Conversation
Add a new command-line flag --terminal (default: true) that allows users to control whether the terminal capability is enabled in clientCapabilities during ACP initialization. Usage: acpx --terminal=false codex exec "list files" acpx --no-terminal codex exec "list files" Changes: - Add terminal option to AcpClientOptions in types.ts - Add --terminal flag to CLI in cli/flags.ts - Pass terminal option through all session runtime functions - Use terminal option in ACP client initialization
# Conflicts: # src/session-runtime.ts # src/session-runtime/prompt-runner.ts
Triage result
Quick readThis PR adds a CLI switch to control whether IntentGive Underlying problem: WhyThis is a Targeted validation was considered necessary because the flag affects multiple runtime entry points, but the flow could not derive a concrete targeted test command. The current validation state is Codex reviewThe solution was judged
Initial merge conflicts were detected earlier against
No separate Codex review findings are available in this handoff state. CI/CDNo CI/CD result is available in this handoff state. No final conflict-gate result is available either. The current run state only records the earlier initial conflict detection plus the validation stop condition. RecommendationEscalate to a human. Recommended next action: identify the correct targeted validation for the new terminal-capability flag behavior, run it, and then decide whether the PR is ready to land. |
Add a new command-line flag --terminal (default: true) that allows users to control whether the terminal capability is enabled in clientCapabilities during ACP initialization.
Usage:
acpx --terminal=false codex exec "list files"
acpx --no-terminal codex exec "list files"
Changes: