Skip to content

test: suppress duplicate remaining-risk prose#20

Merged
clawsweeper[bot] merged 1 commit intomainfrom
clawsweeper/automerge-openclaw-clawsweeper-19
Apr 29, 2026
Merged

test: suppress duplicate remaining-risk prose#20
clawsweeper[bot] merged 1 commit intomainfrom
clawsweeper/automerge-openclaw-clawsweeper-19

Conversation

@clawsweeper
Copy link
Copy Markdown
Contributor

@clawsweeper clawsweeper Bot commented Apr 29, 2026

Carry forward @steipete's automerge smoke regression from #19 with the requested repair: the keep-open PR review comment test should assert that duplicate Remaining risk / open question: prose is suppressed.

Source PR credit: #19 by @steipete.

Validation:

  • pnpm run test:unit
  • pnpm run check

ClawSweeper 🐠 replacement reef notes:

fish notes: model gpt-5.5, reasoning medium; reviewed against bc94cce.

Co-authored-by: Peter Steinberger <58493+steipete@users.noreply.github.com>
@clawsweeper clawsweeper Bot added the clawsweeper Tracked by ClawSweeper automation label Apr 29, 2026
@steipete
Copy link
Copy Markdown
Contributor

/clawsweeper automerge

@clawsweeper clawsweeper Bot added the clawsweeper:automerge Maintainer opted this ClawSweeper PR into bounded ClawSweeper-reviewed automerge label Apr 29, 2026
@clawsweeper
Copy link
Copy Markdown
Contributor Author

clawsweeper Bot commented Apr 29, 2026

ClawSweeper automerge is enabled for this PR.

I added clawsweeper:automerge and asked ClawSweeper to review this head. If ClawSweeper emits a repair marker or requests changes, I will repair/rebase the branch and ask for another review, up to the configured round limit.

A maintainer can pause this with /clawsweeper stop.

@clawsweeper
Copy link
Copy Markdown
Contributor Author

clawsweeper Bot commented Apr 29, 2026

Codex review: needs maintainer review before merge.

What this changes:

The PR adds a unit regression test in test/clawsweeper.test.mjs asserting that keep-open PR review comments suppress duplicate Remaining risk / open question: prose when the work-candidate reason repeats the same text.

Maintainer follow-up before merge:

Normal PR review, CI validation, and duplicate-PR coordination are maintainer actions; the branch itself is the proposed fix, so there is no separate automated repair to queue.

Best possible solution:

Land one canonical passing regression test for duplicate remaining-risk suppression, keep the existing renderer contract unchanged, and retire the duplicate source PR if this replacement is merged.

Acceptance criteria:

  • pnpm run test:unit
  • pnpm run check

What I checked:

  • current renderer suppresses duplicate risks: Current main only emits Remaining risk / open question: when the risks text differs from the maintainer follow-up and best-solution text. (src/clawsweeper.ts:3162, 00524d5fcb52)
  • dedupe comparison helper is present: publicReviewTextDiffers normalizes visible review text and treats exact or containing duplicates as not distinct. (src/clawsweeper.ts:2739, 00524d5fcb52)
  • specific regression test is missing from main: Current main has adjacent keep-open PR comment tests, including duplicate best-solution suppression, but the exact duplicate remaining-risk regression title/text from this PR is not present. (test/clawsweeper.test.mjs:878, 00524d5fcb52)
  • docs describe the intended comment contract: The PR review comment docs say Remaining risk: should appear only when it is not a restatement of the required change or best solution. (docs/pr-review-comments.md:41, 00524d5fcb52)
  • security review pass: The provided PR file list shows a single test file change with 44 additions and no workflow, dependency, lockfile, script, package metadata, secret, permission, downloaded artifact, generated, vendor, or minified-code changes. (test/clawsweeper.test.mjs:908, bc94ccee996d)
  • related source PR remains open: The PR body and timeline identify test: exercise automerge repair smoke #19 as the source smoke regression and state this replacement exists because ClawSweeper could not safely update that source branch; test: exercise automerge repair smoke #19 is still open in the provided context. (d1572999c87e)

Likely related people:

  • steipete: The provided context credits steipete with the original smoke regression in test: exercise automerge repair smoke #19, and steipete requested automerge on this replacement PR. (role: source regression author and follow-up reviewer; confidence: medium; files: test/clawsweeper.test.mjs)
  • github-actions[bot]: Local blame/log history attributes the relevant comment-rendering code and adjacent tests on main to apply-result commit addf3f0. (role: recent current-main maintainer; confidence: low; commits: addf3f07b525; files: src/clawsweeper.ts, test/clawsweeper.test.mjs, docs/pr-review-comments.md)

Remaining risk / open question:

  • This read-only review did not run pnpm run test:unit or pnpm run check; CI or maintainer validation should confirm the added regression test passes before merge.
  • The related source PR test: exercise automerge repair smoke #19 remains open, so maintainers should land only one canonical regression-test PR and close or supersede the duplicate afterward.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 00524d5fcb52.

@steipete
Copy link
Copy Markdown
Contributor

/clawsweeper approve

@clawsweeper clawsweeper Bot added the clawsweeper:human-review ClawSweeper automerge is paused for maintainer review label Apr 29, 2026
@clawsweeper
Copy link
Copy Markdown
Contributor Author

clawsweeper Bot commented Apr 29, 2026

ClawSweeper is pausing automerge for human review.

Source: clawsweeper[bot]
Reason: structured ClawSweeper verdict: needs-human (sha=bc94ccee996d992c0f5a4ba23fa1a48f46cfd973)

I added clawsweeper:human-review and left the final call with a maintainer.

@steipete
Copy link
Copy Markdown
Contributor

/clawsweeper approve

@clawsweeper clawsweeper Bot removed the clawsweeper:human-review ClawSweeper automerge is paused for maintainer review label Apr 29, 2026
@clawsweeper clawsweeper Bot merged commit 0d161c8 into main Apr 29, 2026
1 check passed
@clawsweeper
Copy link
Copy Markdown
Contributor Author

clawsweeper Bot commented Apr 29, 2026

Maintainer-approved ClawSweeper automerge is complete.

Approver: steipete
Head: bc94ccee996d992c0f5a4ba23fa1a48f46cfd973
Merge status: merged by ClawSweeper automerge
Merged at: 2026-04-29T14:11:30Z

The automerge loop is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clawsweeper:automerge Maintainer opted this ClawSweeper PR into bounded ClawSweeper-reviewed automerge clawsweeper Tracked by ClawSweeper automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant