fix: use invariant culture in numeric display formatting#158
Merged
shanselman merged 2 commits intoopenclaw:masterfrom Apr 8, 2026
Merged
Conversation
FormatLargeNumber and CostUsd were using the current thread culture, producing "2,5M" or "$0,25" on non-English locales instead of the expected "2.5M" / "$0.25". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Covers non-English culture formatting so token and cost display stays as 2.5M / .25 rather than locale-specific 2,5M / ,25. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FormatLargeNumberandCostUsdwere formatting values using the current thread culture, producing2,5Mor$0,25on non-English locales instead of the expected2.5M/$0.25. This fixes both helpers to useCultureInfo.InvariantCulture.What changed
FormatLargeNumberandCostUsdnow use invariant culture for all numeric outputTesting
./build.ps1dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restoredotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restoreAll passing.