[Repo Assist] improve: FrozenDictionary command dispatch map in WindowsNodeClient#197
Closed
github-actions[bot] wants to merge 1 commit intomasterfrom
Conversation
Replace O(n) linear capability scans with O(1) FrozenDictionary lookup. - Add _commandMap field (FrozenDictionary<string, INodeCapability>) - Add BuildCommandMap() to (re)build the map after each RegisterCapability call - Replace both FirstOrDefault dispatch calls with _commandMap.GetValueOrDefault - First-registered capability wins on command collision (preserves original semantics) - Add 3 tests: routing, unknown command, first-registered-wins collision Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
11 tasks
Collaborator
|
Superseded by a new PR that includes the event-path dispatch test identified during rubber-duck review. The code change is identical; only test coverage was added. |
shanselman
added a commit
that referenced
this pull request
Apr 23, 2026
…205) * improve: FrozenDictionary command dispatch map in WindowsNodeClient Replace O(n) linear capability scans with O(1) FrozenDictionary lookup. - Add _commandMap field (FrozenDictionary<string, INodeCapability>) - Add BuildCommandMap() to (re)build the map after each RegisterCapability call - Replace both FirstOrDefault dispatch calls with _commandMap.GetValueOrDefault - First-registered capability wins on command collision (preserves original semantics) - Add 3 tests: routing, unknown command, first-registered-wins collision Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * improve: FrozenDictionary command dispatch map in WindowsNodeClient Replace two O(n) FirstOrDefault(c => c.CanHandle(command)) scans with O(1) FrozenDictionary lookup. TryAdd preserves first-registered- wins semantics. Map rebuilt on each RegisterCapability() call (startup only, before ConnectAsync). Add event-path dispatch test to cover HandleNodeInvokeEventAsync in addition to the request-path tests. Based on Repo Assist PR #197, with additional test coverage. Closes #197 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Replace two O(n)
_capabilities.FirstOrDefault(c => c.CanHandle(command))linear scans inWindowsNodeClientwith an O(1)FrozenDictionary<string, INodeCapability>command map.Root Cause / Motivation
Both
HandleNodeInvokeAsyncand thenode.invokeresponse handler dispatch commands by scanning the entire_capabilitieslist. For each incoming request, every capability'sCanHandle()is called in sequence. With many registered capabilities (system, exec, screen capture, future additions), this scales as O(n×m) where n = capabilities and m = commands per capability.FrozenDictionaryis already the established pattern in this codebase for exactly this purpose —ChannelHealth,NotificationCategorizer, andOpenClawGatewayClientall use it for lookups.Changes
WindowsNodeClient.cs_commandMapfield:FrozenDictionary<string, INodeCapability>.EmptyBuildCommandMap(): iterates_capabilitiesand callsTryAddfor eachINodeCapability.CommandsentryRegisterCapability()now callsBuildCommandMap()after adding to_capabilitiesFirstOrDefaultdispatch calls with_commandMap.GetValueOrDefault(command)WindowsNodeClientTests.csMockCapabilityhelper classSemantics Preserved
TryAddsemantics mean the first registered capability wins for any given command string — identical to the originalFirstOrDefaultbehaviour.Trade-offs
BuildCommandMap()is called once perRegisterCapability()call (all registrations happen at startup, beforeConnectAsync, so rebuilding is negligible)_commandMapis atomic in .NET; no locking needed given the single-registration-phase patternTest Status
✅ Build passed
✅ Shared.Tests: 633 passed, 20 skipped (653 total) — 3 new tests added
✅ Tray.Tests: 122 passed