Enable native tooltips for the accounts on Qt >= 6.8.3 #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an OCUtils singleton utility class to expose Qt version information and comparison functionality to QML, enabling native tooltips when the Qt version is greater than 6.8.3.
- Adds the OCUtils class with a qVersion property and compareQVersion method in qmlutils.h and qmlutils.cpp.
- Updates AccountBar.qml to conditionally enable native tooltip popup based on the Qt version.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gui/qmlutils.h | Adds the OCUtils singleton with version properties and methods. |
| src/gui/qmlutils.cpp | Implements the qVersion and compareQVersion functions. |
| src/gui/qml/AccountBar.qml | Uses the compareQVersion method to enable native tooltips conditionally. |
TheOneRing
force-pushed
the
work/native_tooltip
branch
from
f730ad1 to
b2b00d8
Compare
TheOneRing
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.