Handle return key for the url wizard page #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
TheOneRing
commented
May 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds handling of the Enter/Return key to advance the server URL wizard page, replaces a custom PostfixLineEdit with a plain QLineEdit plus validation/fixup logic, and updates several page classes to use const qualifiers on validateInput.
- Connects the new
requestNextsignal to advance the wizard when Enter is pressed - Removes
PostfixLineEditwidget and related files - Introduces a
UrlValidator,fixupUrlhelper, and keyPressEvent override to enforce HTTPS and URL correctness
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/gui/newwizard/states/serverurlsetupwizardstate.cpp | Wired up requestNext signal and simplified URL assignment |
| src/gui/newwizard/postfixlineedit.h / postfixlineedit.cpp | Deleted custom postfix line edit implementation |
| src/gui/newwizard/pages/serverurlsetupwizardpage.ui | Swapped OCC::PostfixLineEdit for QLineEdit and removed custom widget entries |
| src/gui/newwizard/pages/serverurlsetupwizardpage.h | Changed return type of userProvidedUrl, made validateInput const, added keyPressEvent |
| src/gui/newwizard/pages/serverurlsetupwizardpage.cpp | Added UrlValidator, fixupUrl, updated URL logic, implemented Enter key handling |
| src/gui/newwizard/pages/oauthcredentialssetupwizardpage.h/cpp | Marked validateInput as const override |
| src/gui/newwizard/pages/accountconfiguredwizardpage.h/cpp | Marked validateInput as const override |
| src/gui/newwizard/pages/abstractsetupwizardpage.h | Changed validateInput to const, added new requestNext signal |
| src/gui/newwizard/CMakeLists.txt | Removed postfixlineedit.cpp from build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.