Don't truncate inode on Windows #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the inode value was being unnecessarily truncated on Windows systems. The change prevents truncation of the file index information, allowing the full inode value to be preserved locally and triggering proper metadata updates without affecting file content synchronization.
- Removes bitwise AND operation that was truncating the upper 16 bits of the inode value
- Preserves full 64-bit inode information from Windows file system APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inode will be updated locally, as the content didn't change we won't trigger an upload, just a CSYNC_INSTRUCTION_UPDATE_METADATA .
Move detection isn't affected as it was broke for years anyhow see #397
Fixes: #396