Fix massive ram usage with http2 downloads #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/bandwidth
branch
from
e37546c to
3dc94ab
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a memory issue where HTTP/2 downloads could cause excessive RAM usage by buffering entire files when the read buffer size was artificially limited. The fix conditionally applies read buffer size limits only when bandwidth management is active.
Key Changes
- Disables HTTP/2 for downloads when bandwidth management is active to work around Qt buffering behavior
- Conditionalizes all
setReadBufferSize()calls to only execute when_bandwidthManageris present - Fixes typo "badnwidth" → "bandwidth" in error message
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
remove calls to setReadBufferSize when bandwidthmonitor is not used
TheOneRing
force-pushed
the
work/bandwidth
branch
from
4dccd6e to
b2d1ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove calls to setReadBufferSize when bandwidth monitor is not used