multi-tenancy: Optional attributes on provision API #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already optional in the spec. For mulit-tenant provisioning we want it to be optional as well. Related: opencloud-eu#1597
micbar
approved these changes
Oct 28, 2025
micbar
reviewed
Oct 28, 2025
| school.SetDisplayName(displayName) | ||
|
|
||
| if id == "" || displayName == "" { | ||
| i.logger.Warn().Str("dn", e.DN).Str("id", id).Str("displayName", displayName).Msg("Invalid School. Missing required attribute") |
Contributor
There was a problem hiding this comment.
Just out of curiosity, why do we use the Warn() log level?
Contributor
Author
There was a problem hiding this comment.
Good question. I didn't change that so it was added quite a while ago. I guess we could lower it to Info or even Debug because it's not really an error, but just caused by a user sending an invalid request.
Which one would you prefer?
fschade
reviewed
Oct 28, 2025
| case nil: | ||
| logger.Debug().Err(errSchoolNumberExists).Str("schoolNumber", school.GetSchoolNumber()).Msg("duplicate school number") | ||
| return nil, errSchoolNumberExists | ||
| case ErrNotFound: |
Contributor
There was a problem hiding this comment.
errors.Is(err, ErrNotFound)
fschade
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the provisioning API we want the
schoolNumberattribute to be optional for a new School/Tenant. Also the user attributesprimaryRoleandidentitiesare made optional. See #1597