collaboration: Enable InsertRemoteImage option
#1692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndBear
approved these changes
Oct 22, 2025
7 tasks
Contributor
Author
|
@tbsbdr As we introduce a new required config setting here I marked this as a breaking change. So I guess if we merge it, we need to bump the Major Version. |
AlexAndBear
approved these changes
Oct 29, 2025
fschade
approved these changes
Oct 30, 2025
rhafer
force-pushed
the
web/704
branch
2 times, most recently
from
29adda7 to
ed71da3
Compare
This is required for allowing the web office to download images to insert into documents. The secret is generated by `opencloud init` and the server refuses to start now without a secret being set. (Breaking Change) Also the setting is now moved to the shared options as all involved services need the same secret to work properly. Related: opencloud-eu/web#704
When OC_URL_SIGNING_SECRET is not set. Fall back to the value of the reva transfer token. This allows handling upgrades on a instance that was created before the OC_URL_SIGNING_SECRET was introduced to be handled more graceful. Unfortunately this still only works reliably for single instance deployments (or instance that where bootstrapped using 'opencloud init') that are guaranteed to have the transfer token available. When running 'proxy' and 'ocdav' as separate services the upgrade might still require manual intervention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the WOPI properties to enable the UI_InsertGraphic/Action_InsertGraphic PostMessage feature in Collabora.
Setting to draft util CollaboraOnline/online#12331 is sorted out.Related: opencloud-eu/web#704
Related changes to make it work for the opencloud-compose deployment:
opencloud-eu/opencloud-compose#130
As noted elsewhere the feature currently requires the use of properly created certificates for the opencloud instances as Collobora will now download images from servers for which it can't verify the certificates. This can't be turned off currently.
cc @AlexAndBear