Skip to content

correct STORAGE_USERS_POSIX_WATCH_FS env typo in CI #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ScharfViktor merged 3 commits into from
Nov 4, 2025
Merged

correct STORAGE_USERS_POSIX_WATCH_FS env typo in CI #1746

ScharfViktor merged 3 commits into from
Nov 4, 2025

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Oct 30, 2025 •
edited
Loading

I noticed that STORAGE_USERS_POSIX_WATCH_FS was wrong. Corrected it

@ScharfViktor ScharfViktor mentioned this pull request Oct 30, 2025
Open
@ScharfViktor ScharfViktor force-pushed the correctEnvtypo branch 2 times, most recently from dbc6a50 to 0c28121 Compare October 30, 2025 16:20
@ScharfViktor ScharfViktor marked this pull request as ready for review October 30, 2025 16:20
@ScharfViktor ScharfViktor changed the title correct env typo correct STORAGE_USERS_POSIX_WATCH_FS env typo in CI Oct 30, 2025
@fschade fschade marked this pull request as draft October 31, 2025 09:58
@fschade fschade force-pushed the correctEnvtypo branch 3 times, most recently from cfa3cde to 4b258b3 Compare October 31, 2025 12:45
@fschade
Copy link
Contributor

fschade commented Oct 31, 2025

finding:

  Scenario: delete file                                                                         # /woodpecker/src/github.com/opencloud-eu/opencloud/tests/acceptance/features/collaborativePosix/collaborativePosixFS.feature:96
    Given user "Alice" has uploaded file with content "content" to "test.txt"                   # FeatureContext::userHasUploadedAFileWithContentTo()
    When the administrator deletes the file "test.txt" for user "Alice" on the POSIX filesystem # CliContext::theAdministratorDeletesFile()
    Then the command should be successful                                                       # CliContext::theCommandShouldBeSuccessful()
    And as "Alice" file "/test.txt" should not exist                                            # FeatureContext::asFileOrFolderShouldNotExist()
      file '/test.txt' should not exist. But it does.

storage bleed between tests?

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Oct 31, 2025

storage bleed between tests?

it's new. I noticed it today and put to issue #1747

@fschade fschade marked this pull request as ready for review October 31, 2025 14:18
@ScharfViktor ScharfViktor merged commit 59eb411 into main Nov 4, 2025
58 checks passed
@ScharfViktor ScharfViktor deleted the correctEnvtypo branch November 4, 2025 09:22
@openclouders openclouders mentioned this pull request Nov 4, 2025
Merged
1 task
fschade pushed a commit to fschade/opencloud that referenced this pull request Nov 6, 2025
@ScharfViktor @rhafer @fschade
correct STORAGE_USERS_POSIX_WATCH_FS env typo in CI (opencloud-eu#1746)
0dc680c 
* correct env typo

* set STORAGE_USERS_POSIX_SCAN_DEBOUNCE_DELAY=0

* tests: wait for postprocessing to finish before accessing files

---------

Co-authored-by: Ralf Haferkamp <r.haferkamp@opencloud.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhafer rhafer rhafer approved these changes

@individual-it individual-it individual-it approved these changes

@micbar micbar micbar approved these changes

@fschade fschade fschade approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

No one assigned

Labels

Type:Test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ScharfViktor @fschade @rhafer @individual-it @micbar