Archiver should use appropriate filename for resulting archive

[fschrempf]

Is your feature request related to a problem? Please describe.

When downloading a single directory from the UI, the resulting filename is always download.zip.

Describe the solution you'd like

Instead it would be much more user-friendly to name the archive after the selected directory. That's also what is currently implemented in the oCIS reva.

Additional context

• the filename is passed to the browser by setting the `Content-Disposition" header here.
• this defaults to download.zip here for directories and multiple file objects.

I'm not familiar with the codebase and even with go in general, so I'm struggling to provide a PR here. Maybe someone else can solve this or provide a few hints on how to retrieve the directory name from the ResourceId within the CreateZip() or CreateTar().

Thanks!

[rhafer]

Instead it would be much more user-friendly to name the archive after the selected directory. That's also what is currently implemented in the oCIS reva.

AFAICS ocis doesn't behave any different regarding the name of the archive. But I agree, having the zip/tar file named after the directory is a nice idea.

[fschrempf]

AFAICS ocis doesn't behave any different regarding the name of the archive.

Ok, that was probably me mixing up ocis and the CS3 reva code I looked at. The latter actually passes the name here: https://github.com/cs3org/reva/blob/master/internal/http/services/archiver/handler.go#L258.

[rhafer]

@fschrempf Thanks for the pointer. It probably not straight forward to port that over to our code since the archiver is working id based now, but problably not too hard either. At least it's good starting point.

Ah, and I almost forgot. Patches are always welcome. 🙂