-
Notifications
You must be signed in to change notification settings - Fork 14
feat: prepare for deprecating client signed urls #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0dae00e to
cfdb2cb
Compare
PROPFIND requests to '/dav/meta/.../v' now also include the 'oc:downloadURL' property in the response, if requested. Partial: opencloud-eu/opencloud#1197
cfdb2cb to
c69af3d
Compare
|
@JammingBen This introduces a new endpoint for the archive that will redirect to a server signed urls for generating an archive. You'd send a request to Does that make sense for web? Or would you prefer some different kind of interface here? |
c69af3d to
08a052b
Compare
|
Yup this should be fine! Does it work unauthenticated on public links and with basic auth on password-protected links as well? And how would I concatenate multiple ids? |
I'd hope so. But I still need to try.
Just like on the old endpoint |
This introduces the new `archiver/v2` endpoint that leverages the recently added url signing mechanism to generated archive download urls. Request to `archiver/v2?id=...&id=...` will get a 303 Response with the `Location` Header pointing to the signed url that can be used for downloading the archive. Partial: opencloud-eu/opencloud#1197
08a052b to
ab26470
Compare
I can confirm that this works for public links (password protected or not) as well. |
|
Argh, I just noticed I introduced a stupid bug that would allow downloading arbitrary files from the creator of a public link. 🤦♂️ |
PROPFIND requests to '/dav/meta/.../v' now also include the 'oc:downloadURL' property in the response, if requested.
Also the archive is able now to produce signed urls for downloading an archive.
Partial: opencloud-eu/opencloud#1197