fix: search preview design #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in the search preview design that was introduced in a previous pull request. The changes focus on correcting styling issues in the search bar component to restore proper visual appearance.
- Adds margin and padding resets for buttons, links, and list items in the search preview
- Updates hover/active background color to use the correct design token
- Adds specific padding class to the "more results" router link
Comments suppressed due to low confidence (1)
packages/web-app-search/src/portals/SearchBar.vue:76
- [nitpick] The CSS class 'oc-p-rm' is unclear. Consider using a more descriptive class name that indicates its purpose, such as 'oc-padding-remove' or similar.
class="more-results oc-p-rm"
JammingBen
force-pushed
the
fix/search-preview-design
branch
from
73320ab to
e2d0836
Compare
AlexAndBear
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from #997.