e2e-test. fix share with multiple user test #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky end-to-end test related to sharing files with multiple users by addressing a right sidebar flickering issue. The fix involves adding a timeout to stabilize the dropdown interaction during collaborator selection.
- Adds a 200ms timeout before clicking dropdown items to prevent flickering-related test failures
- Refactors the dropdown item selection to use a more stable locator pattern
JammingBen
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky tests caused by right sidebar flickering when sharing with multiple users (issue not reproducible manually)
before:
Screen.Recording.2025-07-25.at.12.57.38.mp4
after:
Screen.Recording.2025-07-25.at.12.58.40.mp4
which tests were affected:
KEYCLOAK=true HEADLESS=false OC_BASE_URL=cloud.opencloud.test KEYCLOAK_HOST=keycloak.opencloud.test pnpm test:e2e:cucumber tests/e2e/cucumber/features/keycloak