fix: resource deselect when clicking esc in a modal #1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents resources from getting deselected when closing modals. The ESC key should only close the modal in that case. This also fixes an issue where the resource conflict dialog would not get focused again after closing it via ESC.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where pressing the ESC key in a modal would unintentionally deselect resources in addition to closing the modal. The change prevents event bubbling by adding the .stop modifier to the ESC keydown handler.
- Adds
.stopmodifier to prevent ESC key events from bubbling up to parent components
AlexAndBear
approved these changes
Aug 5, 2025
openclouders
pushed a commit
that referenced
this pull request
Aug 5, 2025
fix: resource deselect when clicking esc in a modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents resources from getting deselected when closing modals. The ESC key should only close the modal in that case.
This also fixes an issue where the resource conflict dialog would not get focused again after closing it via ESC.
fixes #777