enable upload tests for webkit #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables upload test scenarios for the WebKit browser by removing the @webkit-skip tags from two upload test scenarios and updating the WebKit test command to no longer exclude webkit-skip tagged tests.
Key Changes
- Removed
@webkit-skiptags from two upload test scenarios in the Cucumber feature file - Updated the webkit test command in package.json to remove the
--tags 'not @webkit-skip'filter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/cucumber/features/smoke/upload.feature | Removed @webkit-skip tags from two upload test scenarios to enable them for WebKit testing |
| package.json | Updated webkit test command to remove the webkit-skip tag exclusion filter |
Comments suppressed due to low confidence (1)
JammingBen
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were disabled due to an issue with infinite loading after creating a .txt file and closing the editor.
This issue is not reproducible locally, but occurs in the CI environment.
As a workaround, page.reload() is used after closing the editor to restore normal behavior in tests.