fix: dynamic viewport height on mobile devices #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes viewport height issues on mobile devices by replacing the traditional 100vh CSS unit with the newer 100dvh (dynamic viewport height) unit. This addresses mobile browser behavior where the viewport height changes as browser UI elements (like address bars) show or hide during scrolling.
- Replace
100vhwith100dvhfor dynamic viewport height - Update both height and max-height properties to use the new unit
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-runtime/src/layouts/Application.vue | Updates main layout height to use dynamic viewport height |
| packages/web-runtime/src/App.vue | Updates root web element height and max-height to use dynamic viewport height |
Comments suppressed due to low confidence (3)
packages/web-runtime/src/layouts/Application.vue:202
- The
100dvhunit has limited browser support. Consider adding a fallback usingheight: 100vh; height: 100dvh;to ensure compatibility with older browsers that don't support dynamic viewport units.
height: 100dvh;
packages/web-runtime/src/App.vue:144
- The
100dvhunit has limited browser support. Consider adding a fallback usingheight: 100vh; height: 100dvh;to ensure compatibility with older browsers that don't support dynamic viewport units.
height: 100dvh;
packages/web-runtime/src/App.vue:145
- The
100dvhunit has limited browser support. Consider adding a fallback usingmax-height: 100vh; max-height: 100dvh;to ensure compatibility with older browsers that don't support dynamic viewport units.
max-height: 100dvh;
AlexAndBear
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #822 (thanks to @heijligen for providing the patch).