feat: change bottom drawer to less technical context menu label #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the accessibility labels for the bottom drawer component to use more user-friendly language by changing "Close the bottom drawer" to "Close the context menu".
- Updates aria-label text for better user experience and accessibility
- Changes technical terminology to more contextually appropriate language
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| OcBottomDrawer.vue | Updates aria-label attributes from "Close the bottom drawer" to "Close the context menu" |
| OcBottomDrawer.spec.ts.snap | Updates test snapshots to reflect the new aria-label text |
JammingBen
previously approved these changes
Aug 7, 2025
kulmann
force-pushed
the
adjust-bottom-drawer-label
branch
from
671df64 to
fd3518a
Compare
kulmann
commented
Aug 11, 2025
| ref="bottomDrawerRef" | ||
| class="oc-bottom-drawer-background" | ||
| role="button" | ||
| :aria-label="$gettext('Close the bottom drawer')" |
Contributor
Author
There was a problem hiding this comment.
I removed the aria-label, because it would replace (!) the accessible content of the entire <div>. Don't know if it's needed at all, but if yes, we could use aria-describedby instead. I'd prefer to leave it out. Also not sure if we really need the button role here.
JammingBen
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change
Close the bottom drawerlabel to a less technicalClose the context menu.