refactor: font-weight and text-decoration to tailwind #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
changed the title
JammingBen
changed the title
JammingBen
force-pushed
the
refactor/font-weight-tailwind
branch
from
7ebda20 to
878d020
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors font-weight and text-decoration utilities from custom CSS classes to Tailwind CSS utilities. The migration focuses on replacing custom utilities like oc-font-semibold and oc-text-bold with standard Tailwind classes such as font-semibold and font-bold, while also removing custom text-decoration styles in favor of Tailwind's hover:underline utility.
Key Changes
- Migration of font-weight utilities from custom CSS classes to Tailwind equivalents
- Replacement of custom text-decoration styles with Tailwind's hover utilities
- Updates to design system components and application code to use standardized Tailwind classes
Reviewed Changes
Copilot reviewed 65 out of 65 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/design-system/src/styles/theme/oc-text.scss | Removes default text-decoration from anchor tags |
| packages/design-system/src/components/OcTableTh/OcTableTh.vue | Migrates font-weight styling to Tailwind utilities |
| packages/design-system/src/components/OcTable/OcTable.vue | Adds hover:underline class to sort buttons |
| packages/web-pkg/src/components/FilesList/ResourceName.vue | Replaces custom hover text-decoration with Tailwind class |
| packages/web-runtime/src/App.vue | Migrates mark-highlight styling to Tailwind utilities |
| Various test snapshots | Updates test expectations to reflect new Tailwind class usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
force-pushed
the
refactor/font-weight-tailwind
branch
from
d7fe322 to
5397016
Compare
AlexAndBear
approved these changes
Aug 20, 2025
JammingBen
force-pushed
the
refactor/font-weight-tailwind
branch
from
5397016 to
8985574
Compare
JammingBen
force-pushed
the
refactor/font-weight-tailwind
branch
from
8985574 to
bdfa8ed
Compare
openclouders
pushed a commit
that referenced
this pull request
Aug 20, 2025
refactor: font-weight and text-decoration to tailwind
kulmann
reviewed
Aug 20, 2025
| v-for="(item, index) in listItems" | ||
| :key="index" | ||
| :class="{ 'ml-0': !item.headline, 'first:mt-0': item.headline }" | ||
| :class="{ |
Contributor
There was a problem hiding this comment.
The text of contextual helpers is now bold. That looks weird. Was normal weight before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #937
Migration
oc-font-semibold>font-semiboldoc-text-bold>font-semiboldSee here for the weight values: https://tailwindcss.com/docs/font-weight
For
text-decorationwe didn't have a utility class. When a decoration is needed on hover, just usehover:underline. Disabling the underline is usually not needed since this is already done via the tailwind preflight.