-
Notifications
You must be signed in to change notification settings - Fork 25
refactor: width to tailwind #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d068c0d to
ce6273c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates custom CSS width classes to Tailwind utilities as part of a broader refactoring effort. The changes replace legacy oc-width-* classes with their Tailwind equivalents and convert inline styles and SCSS width declarations to utility classes.
- Replaces custom width classes with Tailwind equivalents (e.g.,
oc-width-1-1→w-full) - Converts inline width styles to Tailwind utilities
- Removes custom SCSS width declarations in favor of utility classes
Reviewed Changes
Copilot reviewed 168 out of 168 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/resource/actions.ts | Updates CSS selectors for breadcrumb elements |
| Multiple snapshot files | Updates test snapshots with new Tailwind width classes |
| packages/web-runtime/src/ | Converts width classes in layout components and pages |
| packages/web-pkg/src/ | Migrates shared component width styles to Tailwind |
| packages/web-app-*/src/ | Updates app-specific components with Tailwind width utilities |
Comments suppressed due to low confidence (1)
packages/web-runtime/src/components/Topbar/UserMenu.vue:1
- The inline styles for width and height should be converted to Tailwind utilities for consistency with the PR's migration goal. Consider using
class='w-8 h-8'instead of inline styles.
<template>
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
db511f6 to
2f747ba
Compare
refactor: width to tailwind
Migrates
width,max-widthandmin-widthto Tailwind. Also migrates someheightwhen both are the same, since we can usesize-then.refs #937
Migration
oc-width-1-1>w-fulloc-width-1>w-fulloc-width-large>w-lgoc-width-medium>w-smoc-width-small>w-xsoc-width-expand>flex-1oc-width-auto>w-auto