Skip to content

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Aug 26, 2025

Migrates width, max-width and min-width to Tailwind. Also migrates some height when both are the same, since we can use size- then.

refs #937

Migration

  • oc-width-1-1 > w-full
  • oc-width-1 > w-full
  • oc-width-large > w-lg
  • oc-width-medium > w-sm
  • oc-width-small > w-xs
  • oc-width-expand > flex-1
  • oc-width-auto > w-auto

@JammingBen JammingBen self-assigned this Aug 26, 2025
@JammingBen JammingBen force-pushed the refactor/tailwind-width branch from d068c0d to ce6273c Compare August 27, 2025 13:23
@JammingBen JammingBen marked this pull request as ready for review August 27, 2025 13:26
Copilot AI review requested due to automatic review settings August 27, 2025 13:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates custom CSS width classes to Tailwind utilities as part of a broader refactoring effort. The changes replace legacy oc-width-* classes with their Tailwind equivalents and convert inline styles and SCSS width declarations to utility classes.

  • Replaces custom width classes with Tailwind equivalents (e.g., oc-width-1-1w-full)
  • Converts inline width styles to Tailwind utilities
  • Removes custom SCSS width declarations in favor of utility classes

Reviewed Changes

Copilot reviewed 168 out of 168 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/e2e/support/objects/app-files/resource/actions.ts Updates CSS selectors for breadcrumb elements
Multiple snapshot files Updates test snapshots with new Tailwind width classes
packages/web-runtime/src/ Converts width classes in layout components and pages
packages/web-pkg/src/ Migrates shared component width styles to Tailwind
packages/web-app-*/src/ Updates app-specific components with Tailwind width utilities
Comments suppressed due to low confidence (1)

packages/web-runtime/src/components/Topbar/UserMenu.vue:1

  • The inline styles for width and height should be converted to Tailwind utilities for consistency with the PR's migration goal. Consider using class='w-8 h-8' instead of inline styles.
<template>

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen force-pushed the refactor/tailwind-width branch from db511f6 to 2f747ba Compare August 28, 2025 05:46
@JammingBen JammingBen merged commit d199968 into main Aug 28, 2025
28 checks passed
@JammingBen JammingBen deleted the refactor/tailwind-width branch August 28, 2025 06:13
openclouders pushed a commit that referenced this pull request Aug 28, 2025
@openclouders openclouders mentioned this pull request Aug 28, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants