Skip to content

Conversation

@JammingBen
Copy link
Contributor

See commits for details.

refs #937

@JammingBen JammingBen self-assigned this Aug 27, 2025
Copilot AI review requested due to automatic review settings August 27, 2025 14:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes various Tailwind CSS regressions by updating utility classes to maintain visual consistency across components. The changes primarily involve replacing deprecated or incorrect CSS classes with proper Tailwind equivalents.

  • Replaces border with outline for better visual rendering
  • Updates height specifications using bracket notation for precise values
  • Adjusts spacing and layout classes for improved component appearance

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/web-runtime/src/components/Topbar/NotificationBell.vue Adds box-content class to notification badge
packages/web-pkg/src/components/Filters/ItemFilterInline.vue Replaces border with outline and removes custom SCSS height styles
packages/web-pkg/src/components/FilesList/ResourceTiles.vue Reduces top padding from pt-6 to pt-2
packages/web-pkg/src/components/SideBar/Spaces/Details/SpaceDetails.vue Adds bottom margin to space image container
packages/web-app-ocm/src/views/App.vue Adds margin to connections panel container
packages/web-app-files/src/components/Search/List.vue Adds max-w-full class to search highlights
packages/web-app-app-store/src/components/AppTile.vue Adds top margin to app actions component
packages/design-system/src/components/OcRecipient/OcRecipient.vue Replaces border with outline and align-center with items-center
packages/design-system/src/components/OcFilterChip/OcFilterChip.vue Adds explicit height and removes conflicting CSS
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue Adds border radius to dragover state
packages/design-system/src/styles/layers.css Adds break-all to tooltip content
index.html Updates splash screen layout and styling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

<template>
<span
class="oc-recipient bg-role-surface-container flex align-center justify-center border border-role-outline rounded-md"
class="oc-recipient bg-role-surface-container flex items-center justify-center outline outline-role-outline rounded-md"
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using outline instead of border may cause accessibility issues as outlines are typically reserved for focus indicators. Consider using border with appropriate offset adjustments if visual consistency is the goal.

Suggested change
class="oc-recipient bg-role-surface-container flex items-center justify-center outline outline-role-outline rounded-md"
class="oc-recipient bg-role-surface-container flex items-center justify-center border border-role-outline rounded-md"

Copilot uses AI. Check for mistakes.
@JammingBen JammingBen merged commit e90f1d6 into main Aug 28, 2025
29 checks passed
@JammingBen JammingBen deleted the fix/tailwind-regressions-1 branch August 28, 2025 05:40
openclouders pushed a commit that referenced this pull request Aug 28, 2025
@openclouders openclouders mentioned this pull request Aug 28, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants