-
Notifications
You must be signed in to change notification settings - Fork 25
fix: tailwind regressions #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes various Tailwind CSS regressions by updating utility classes to maintain visual consistency across components. The changes primarily involve replacing deprecated or incorrect CSS classes with proper Tailwind equivalents.
- Replaces
borderwithoutlinefor better visual rendering - Updates height specifications using bracket notation for precise values
- Adjusts spacing and layout classes for improved component appearance
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/components/Topbar/NotificationBell.vue | Adds box-content class to notification badge |
| packages/web-pkg/src/components/Filters/ItemFilterInline.vue | Replaces border with outline and removes custom SCSS height styles |
| packages/web-pkg/src/components/FilesList/ResourceTiles.vue | Reduces top padding from pt-6 to pt-2 |
| packages/web-pkg/src/components/SideBar/Spaces/Details/SpaceDetails.vue | Adds bottom margin to space image container |
| packages/web-app-ocm/src/views/App.vue | Adds margin to connections panel container |
| packages/web-app-files/src/components/Search/List.vue | Adds max-w-full class to search highlights |
| packages/web-app-app-store/src/components/AppTile.vue | Adds top margin to app actions component |
| packages/design-system/src/components/OcRecipient/OcRecipient.vue | Replaces border with outline and align-center with items-center |
| packages/design-system/src/components/OcFilterChip/OcFilterChip.vue | Adds explicit height and removes conflicting CSS |
| packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue | Adds border radius to dragover state |
| packages/design-system/src/styles/layers.css | Adds break-all to tooltip content |
| index.html | Updates splash screen layout and styling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <template> | ||
| <span | ||
| class="oc-recipient bg-role-surface-container flex align-center justify-center border border-role-outline rounded-md" | ||
| class="oc-recipient bg-role-surface-container flex items-center justify-center outline outline-role-outline rounded-md" |
Copilot
AI
Aug 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using outline instead of border may cause accessibility issues as outlines are typically reserved for focus indicators. Consider using border with appropriate offset adjustments if visual consistency is the goal.
| class="oc-recipient bg-role-surface-container flex items-center justify-center outline outline-role-outline rounded-md" | |
| class="oc-recipient bg-role-surface-container flex items-center justify-center border border-role-outline rounded-md" |
fix: tailwind regressions
See commits for details.
refs #937