chore: adjust position css props to tailwind #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndBear
force-pushed
the
tailwind-position-classes
branch
from
99523af to
1a3a8bc
Compare
JammingBen
force-pushed
the
tailwind-position-classes
branch
from
1a3a8bc to
ed31885
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates position-related CSS properties from custom OC design system classes to Tailwind CSS utilities. The migration systematically replaces custom position classes like oc-position-relative, oc-position-fixed, etc. with their equivalent Tailwind utilities such as relative, fixed, absolute, and more complex positioning combinations.
- Replaces custom OC position utility classes with standard Tailwind equivalents
- Migrates complex positioning like
oc-position-centerto Tailwind combinations using transforms - Updates both component files and their corresponding test snapshots
- Removes obsolete CSS rules from SCSS files after migration
Reviewed Changes
Copilot reviewed 73 out of 73 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/pages/*.vue | Updates login pages to use Tailwind absolute positioning |
| packages/web-runtime/src/layouts/Application.vue | Migrates progress bar and snackbar positioning |
| packages/web-runtime/src/components/Topbar/*.vue | Updates notification and topbar positioning |
| packages/web-runtime/src/components/SidebarNav/*.vue | Migrates sidebar navigation positioning |
| packages/web-runtime/src/components/SkipTo.vue | Updates skip link positioning |
| packages/web-pkg/src/components/**/*.vue | Comprehensive position class migration across components |
| packages/web-app-/src/**/.vue | Updates position classes in all web applications |
| packages/design-system/src/components/**/*.vue | Migrates design system component positioning |
| packages/design-system/src/styles/*.scss | Removes obsolete position CSS rules |
| **/*.snap | Updates test snapshots to reflect new Tailwind classes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kulmann
reviewed
Sep 2, 2025
packages/design-system/src/components/OcNotifications/OcNotifications.spec.ts
Show resolved
Hide resolved
openclouders
pushed a commit
that referenced
this pull request
Sep 2, 2025
chore: adjust position css props to tailwind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #937
Migration
oc-position-relative>relativeoc-position-fixed>fixedoc-position-absolute>absoluteoc-position-center>absolute top-[50%] left-[50%] transform-[translate(-50%, -50%)]oc-position-center-right>absolute top-[50%] right-0 transform-[translateY(-50%)]oc-position-bottom-center>absolute left-[50%] bottom-0 transform-[translateX(-50%)]oc-position-cover>absolute inset-0The transform might not be necessary, depends on the situation.