Skip to content

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Sep 5, 2025

refs #937

Migration

  • oc-invisible-sr > sr-only
  • oc-cursor-pointer > cursor-pointer
  • oc-invisible > invisible
  • oc-hidden > hidden

For the oc-visible@ classes, you generally want to set hidden on the element and then something like sm:block (or whatever display value fits). For oc-hidden@ it's the same but vice versa.

@JammingBen JammingBen self-assigned this Sep 5, 2025
@JammingBen JammingBen force-pushed the refactor/remaining-css-to-tailwind branch from 1e6d3d7 to d123858 Compare September 5, 2025 08:43
@JammingBen JammingBen marked this pull request as ready for review September 5, 2025 09:36
Copilot AI review requested due to automatic review settings September 5, 2025 09:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates remaining CSS utility classes to Tailwind equivalents, specifically replacing custom oc- prefixed classes with standard Tailwind classes.

  • oc-invisible-srsr-only for screen reader only content
  • oc-cursor-pointercursor-pointer for pointer cursor styling
  • oc-invisibleinvisible for hiding elements

Reviewed Changes

Copilot reviewed 80 out of 80 changed files in this pull request and generated no comments.

File Description
Multiple test snapshot files Updated snapshots to reflect CSS class name changes
Multiple Vue component files Replaced custom CSS classes with Tailwind equivalents
Multiple SCSS/CSS files Removed custom CSS rules now handled by Tailwind
Test files Updated test assertions to check for new class names
Comments suppressed due to low confidence (1)

packages/web-app-ocm/src/views/ConnectionsPanel.vue:1

  • The CSS property visibility: none is invalid. The correct value should be visibility: hidden.
<template>

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen force-pushed the refactor/remaining-css-to-tailwind branch from bf79667 to 2ff53af Compare September 5, 2025 09:39
@JammingBen JammingBen requested a review from kulmann September 5, 2025 09:42
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@JammingBen JammingBen force-pushed the refactor/remaining-css-to-tailwind branch from f19a103 to 384b8b1 Compare September 5, 2025 12:32
@JammingBen JammingBen merged commit 6cfd21c into main Sep 5, 2025
28 checks passed
@JammingBen JammingBen deleted the refactor/remaining-css-to-tailwind branch September 5, 2025 12:51
openclouders pushed a commit that referenced this pull request Sep 5, 2025
…tailwind

refactor: remaining css to tailwind #1
@openclouders openclouders mentioned this pull request Sep 5, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants