Skip to content

Conversation

@JammingBen
Copy link
Contributor

refs #937

@JammingBen JammingBen self-assigned this Sep 5, 2025
@JammingBen JammingBen marked this pull request as ready for review September 5, 2025 10:15
Copilot AI review requested due to automatic review settings September 5, 2025 10:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR continues the refactoring effort to replace CSS properties with Tailwind utilities. The changes systematically convert various styling properties including user-select, background properties, border-radius, display rules, transitions, and other CSS properties to their Tailwind equivalents across multiple components.

  • Converts CSS properties like user-select: none to select-none utility class
  • Replaces background-related properties with Tailwind utilities (bg-center, bg-no-repeat, etc.)
  • Converts display and layout properties to Tailwind equivalents
  • Updates test snapshots to reflect the new class additions

Reviewed Changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/design-system/src/components/OcAvatar/OcAvatar.vue Adds select-none class and removes corresponding SCSS
packages/design-system/src/components/OcAvatarItem/OcAvatarItem.vue Converts background properties to Tailwind utilities
packages/design-system/src/components/OcCheckbox/OcCheckbox.vue Adds appearance and background utilities, removes SCSS equivalents
packages/design-system/src/components/OcRadio/OcRadio.vue Converts appearance and background properties to Tailwind
packages/design-system/src/components/OcSpinner/OcSpinner.vue Moves border-bottom-color to Tailwind utility
packages/design-system/src/components/OcSwitch/OcSwitch.vue Converts border-radius property to Tailwind
packages/design-system/src/components/OcTable/OcTable.vue Removes border-collapse and border-spacing SCSS
packages/web-runtime/src/components/Topbar/TopBar.vue Adds select-none and reorganizes styles
packages/web-runtime/src/components/SidebarNav/SidebarNavItem.vue Converts user-select to Tailwind utility
packages/web-pkg/src/components/SearchBarFilter.vue Converts CSS utilities to Tailwind classes
packages/web-pkg/src/components/BatchActions.vue Replaces SCSS with Tailwind utilities for layout
packages/web-app-files/src/components/Spaces/SpaceHeader.vue Converts webkit-mask-image to Tailwind utility
packages/web-app-admin-settings/src/components/Users/UsersList.vue Converts display properties to Tailwind breakpoint utilities
Test snapshot files Updates to reflect new Tailwind class additions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen requested a review from kulmann September 5, 2025 10:20
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@JammingBen JammingBen force-pushed the refactor/remaining-css-to-tailwind-2 branch from b647011 to 7734a55 Compare September 5, 2025 12:31
@JammingBen JammingBen force-pushed the refactor/remaining-css-to-tailwind-2 branch from 7734a55 to fbdb7a3 Compare September 5, 2025 12:57
@JammingBen JammingBen merged commit a808778 into main Sep 5, 2025
28 checks passed
@JammingBen JammingBen deleted the refactor/remaining-css-to-tailwind-2 branch September 5, 2025 13:12
openclouders pushed a commit that referenced this pull request Sep 5, 2025
…tailwind-2

refactor: remaining css props to tailwind #2
@openclouders openclouders mentioned this pull request Sep 5, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants