-
Notifications
You must be signed in to change notification settings - Fork 25
refactor: remaining css props to tailwind #2 #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR continues the refactoring effort to replace CSS properties with Tailwind utilities. The changes systematically convert various styling properties including user-select, background properties, border-radius, display rules, transitions, and other CSS properties to their Tailwind equivalents across multiple components.
- Converts CSS properties like
user-select: nonetoselect-noneutility class - Replaces background-related properties with Tailwind utilities (
bg-center,bg-no-repeat, etc.) - Converts display and layout properties to Tailwind equivalents
- Updates test snapshots to reflect the new class additions
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/design-system/src/components/OcAvatar/OcAvatar.vue | Adds select-none class and removes corresponding SCSS |
| packages/design-system/src/components/OcAvatarItem/OcAvatarItem.vue | Converts background properties to Tailwind utilities |
| packages/design-system/src/components/OcCheckbox/OcCheckbox.vue | Adds appearance and background utilities, removes SCSS equivalents |
| packages/design-system/src/components/OcRadio/OcRadio.vue | Converts appearance and background properties to Tailwind |
| packages/design-system/src/components/OcSpinner/OcSpinner.vue | Moves border-bottom-color to Tailwind utility |
| packages/design-system/src/components/OcSwitch/OcSwitch.vue | Converts border-radius property to Tailwind |
| packages/design-system/src/components/OcTable/OcTable.vue | Removes border-collapse and border-spacing SCSS |
| packages/web-runtime/src/components/Topbar/TopBar.vue | Adds select-none and reorganizes styles |
| packages/web-runtime/src/components/SidebarNav/SidebarNavItem.vue | Converts user-select to Tailwind utility |
| packages/web-pkg/src/components/SearchBarFilter.vue | Converts CSS utilities to Tailwind classes |
| packages/web-pkg/src/components/BatchActions.vue | Replaces SCSS with Tailwind utilities for layout |
| packages/web-app-files/src/components/Spaces/SpaceHeader.vue | Converts webkit-mask-image to Tailwind utility |
| packages/web-app-admin-settings/src/components/Users/UsersList.vue | Converts display properties to Tailwind breakpoint utilities |
| Test snapshot files | Updates to reflect new Tailwind class additions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
b647011 to
7734a55
Compare
7734a55 to
fbdb7a3
Compare
…tailwind-2 refactor: remaining css props to tailwind #2
refs #937