Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 8, 2025

Description

image image

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Sep 8, 2025
@github-project-automation github-project-automation bot moved this to Qualification in OpenCloud Team Board Sep 8, 2025
@AlexAndBear AlexAndBear marked this pull request as ready for review September 8, 2025 10:05
Copilot AI review requested due to automatic review settings September 8, 2025 10:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a mobile-specific view mode switch to the ViewOptions component, allowing users to switch between different view modes (table, tiles, etc.) on mobile devices through a dropdown interface.

  • Adds a mobile-only dropdown component for view mode switching
  • Updates tooltip and aria-label text for desktop view mode buttons to use "Switch to [viewMode]" format
  • Removes "Switch to" prefix from view mode labels to make them more concise

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/web-pkg/src/components/ViewOptions.vue Adds mobile dropdown for view mode selection and updates desktop button labels
packages/web-app-files/src/composables/extensions/useFolderViews.ts Updates view mode labels to remove "Switch to" prefix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise, aesthetically it's a bit different than other, smilar menus like the share role dropdown or the tile view sorting options (missing the blue-ish background on the active element, the check icon is a bit smaller on yours).

@AlexAndBear
Copy link
Contributor Author

LGTM code-wise, aesthetically it's a bit different than other, smilar menus like the share role dropdown or the tile view sorting options (missing the blue-ish background on the active element, the check icon is a bit smaller on yours).

updated

@ScharfViktor ScharfViktor self-assigned this Sep 8, 2025
@ScharfViktor ScharfViktor moved this from Qualification to Needs Tests in OpenCloud Team Board Sep 8, 2025
@AlexAndBear AlexAndBear merged commit 9422f39 into main Sep 8, 2025
28 checks passed
@AlexAndBear AlexAndBear deleted the issues/1140 branch September 8, 2025 12:45
@github-project-automation github-project-automation bot moved this from Needs Tests to Done in OpenCloud Team Board Sep 8, 2025
@ScharfViktor ScharfViktor moved this from Done to Needs Tests in OpenCloud Team Board Sep 8, 2025
@openclouders openclouders mentioned this pull request Sep 8, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Tests

Development

Successfully merging this pull request may close these issues.

web-app-files: Display viewmode-switch-buttons on mobile view ports

4 participants