-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add view mode switch to mobile view #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a mobile-specific view mode switch to the ViewOptions component, allowing users to switch between different view modes (table, tiles, etc.) on mobile devices through a dropdown interface.
- Adds a mobile-only dropdown component for view mode switching
- Updates tooltip and aria-label text for desktop view mode buttons to use "Switch to [viewMode]" format
- Removes "Switch to" prefix from view mode labels to make them more concise
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/web-pkg/src/components/ViewOptions.vue | Adds mobile dropdown for view mode selection and updates desktop button labels |
| packages/web-app-files/src/composables/extensions/useFolderViews.ts | Updates view mode labels to remove "Switch to" prefix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code-wise, aesthetically it's a bit different than other, smilar menus like the share role dropdown or the tile view sorting options (missing the blue-ish background on the active element, the check icon is a bit smaller on yours).
updated |
Description
Related Issue
viewmode-switch-buttonson mobile view ports #1140How Has This Been Tested?
Types of changes