chore!: remove token generation and unnecessary theming options #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
added
Type:Maintenance
JammingBen
commented
Sep 9, 2025
Comment on lines
-371
to
-373
| app.use(designSystem, { | ||
| tokens: currentTheme.value.designTokens | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
The theme store already applies tokens to html, no need for the design-system to do it again.
JammingBen
force-pushed
the
refactor/remove-scss
branch
from
c400099 to
bc4e00d
Compare
There is no need to generate tokens for our default CSS variables anymore, we can just define them via CSS and extract them for the design-system docs where we want to list them.
This includes breakpoints, spacing, font-size, size.
JammingBen
force-pushed
the
refactor/remove-token-generation
branch
from
d91122a to
6e1122a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes token generation infrastructure and unnecessary theming options to reduce system complexity. The changes eliminate the build-tokens system, simplify design token handling by moving to hardcoded defaults, and streamline the theming API.
- Removes token generation build system and related dependencies
- Replaces dynamic theme token loading with static CSS defaults
- Simplifies design system API by removing unused token categories
Reviewed Changes
Copilot reviewed 36 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/container/bootstrap.ts | Removes token passing to design system and simplifies theme initialization |
| packages/web-pkg/src/composables/piniaStores/theme.ts | Removes unused design token categories (breakpoints, fontSizes, sizes, spacing) |
| packages/web-pkg/src/composables/viewMode/useTileSize.ts | Replaces dynamic CSS variable reading with hardcoded pixel values |
| packages/design-system/src/styles/defaults.css | Adds hardcoded CSS custom properties replacing generated tokens |
| packages/design-system/src/index.ts | Removes unused token initialization for removed categories |
| packages/design-system/docs/.vitepress/config.ts | Adds CSS vars generator and removes token-related documentation |
| packages/design-system/package.json | Removes token generation scripts and dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kulmann
approved these changes
Sep 12, 2025
Contributor
There was a problem hiding this comment.
did you "sync" the color roles with the ones in the opencloud default theme?
openclouders
pushed a commit
that referenced
this pull request
Sep 12, 2025
…ration chore!: remove token generation and unnecessary theming options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for the full Tailwind migration guide: https://docs.opencloud.eu/design-system/gettingStarted/tailwindMigration.html
There is just no need for these things anymore, they just add unnecessary complexity.
refs #937