Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Sep 17, 2025

Description

await page.locator(closeSidebarSubPanelBtn).isVisible() --> is FLAKY don't use it https://playwright.dev/docs/api/class-locator#locator-is-visible

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@ScharfViktor ScharfViktor marked this pull request as ready for review September 17, 2025 08:03
Copilot AI review requested due to automatic review settings September 17, 2025 08:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a flaky test in the sidebar closing functionality by replacing unstable visibility checks with Playwright's built-in expect assertions. The change addresses test flakiness related to timing issues when determining which sidebar button is visible.

  • Replaces manual isVisible() check with expect().toBeVisible() for more reliable element detection
  • Uses Playwright's or() locator to handle either sub-panel or root panel button visibility
  • Removes arbitrary timeout that was previously used to wait for sidebar transitions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ScharfViktor
Copy link
Contributor Author

I restarted the pipeline several times. It seems the flaky is gone.

@ScharfViktor ScharfViktor merged commit ea7d951 into main Sep 17, 2025
29 checks passed
@ScharfViktor ScharfViktor deleted the fixSharingStep branch September 17, 2025 08:38
@openclouders openclouders mentioned this pull request Sep 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QA] e2e test failure in Opencloud Nightly CI build

3 participants