App store style fixes #1218
Merged
App store style fixes #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes styling regressions from the Tailwind migration, primarily focusing on the app store components. The changes improve spacing, borders, and visual consistency while updating the global card component border radius.
- Removed excessive margins and improved spacing consistency in app store views
- Enhanced visual styling with cursor pointer on tags and removed unnecessary height constraints
- Updated OcCard border radius from
border-smtoborder-mdglobally - Fixed TextEditor preview background color
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-pkg/src/components/TextEditor/TextEditor.vue | Added transparent background for text editor preview component |
| packages/web-app-app-store/src/views/AppList.vue | Reorganized margins for better spacing between filter controls and app list |
| packages/web-app-app-store/src/views/AppDetails.vue | Removed padding from app content container |
| packages/web-app-app-store/src/components/AppTile.vue | Removed height constraint for better responsive layout |
| packages/web-app-app-store/src/components/AppTags.vue | Added cursor pointer for better UX on clickable tags |
| packages/design-system/src/components/OcCard/OcCard.vue | Updated global card border radius from small to medium |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some smaller regressions from the tailwind migration, mainly in the app store app.
Attention: This also changes the OcCard border radius from
border-smtoborder-md, as I found this generally more appealing. Please review/observe this carefully throughout the UI, if you agree.Related Issue
Types of changes