-
Notifications
You must be signed in to change notification settings - Fork 25
feat: remove edit space description inline button #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the inline edit button from the space description/readme section in the space header component to improve visual consistency and address styling challenges.
- Removes the edit description inline button that was displayed next to the markdown content
- Eliminates associated computed properties and imports that are no longer needed
- Simplifies the CSS class structure for the markdown container
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@tbsbdr assigning you as a reviewer, because while this improves rendered appearance and usability-consistency it also is not as "in your face" anymore how to edit the space description. One has to click the context menu of the space. Please note: we also don't offer an image upload when clicking on the image or a title/subtitle edit for the space, why would we allow to edit the description from an inline-button then? |
c190906 to
f7e8ed9
Compare
| }" | ||
| > | ||
| <text-editor | ||
| class="markdown-container-content w-full [&_#text-editor-preview-component]:!bg-transparent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bg-transparent is not needed here anymore, because I fixed that in den text-editor component styles in another PR.
I woudl say its less about consistency. more important is, that the most frequent actions are "in your face" and the less frequent get a backseat. editing the space description turned out to be less frequently used at least from what I see out there. |
tbsbdr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Removing the edit space description inline-button from the space header. It's supposed to be pretty for everyone, not only for those who can't edit the description. ;-) Also, aligning the button vertically is virtually impossible because it depends on the vertical paddings of the rendered content - which is different if some headline or block text is used.
Types of changes