Skip to content

Conversation

@kulmann
Copy link
Contributor

@kulmann kulmann commented Sep 18, 2025

Description

Removing the edit space description inline-button from the space header. It's supposed to be pretty for everyone, not only for those who can't edit the description. ;-) Also, aligning the button vertically is virtually impossible because it depends on the vertical paddings of the rendered content - which is different if some headline or block text is used.

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copilot AI review requested due to automatic review settings September 18, 2025 09:46
@kulmann kulmann self-assigned this Sep 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the inline edit button from the space description/readme section in the space header component to improve visual consistency and address styling challenges.

  • Removes the edit description inline button that was displayed next to the markdown content
  • Eliminates associated computed properties and imports that are no longer needed
  • Simplifies the CSS class structure for the markdown container

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kulmann
Copy link
Contributor Author

kulmann commented Sep 18, 2025

@tbsbdr assigning you as a reviewer, because while this improves rendered appearance and usability-consistency it also is not as "in your face" anymore how to edit the space description. One has to click the context menu of the space.

Please note: we also don't offer an image upload when clicking on the image or a title/subtitle edit for the space, why would we allow to edit the description from an inline-button then?

@tammi-23 tammi-23 self-assigned this Sep 18, 2025
@kulmann kulmann force-pushed the remove-edit-space-description branch from c190906 to f7e8ed9 Compare September 18, 2025 11:24
}"
>
<text-editor
class="markdown-container-content w-full [&_#text-editor-preview-component]:!bg-transparent"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bg-transparent is not needed here anymore, because I fixed that in den text-editor component styles in another PR.

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 18, 2025

Please note: we also don't offer an image upload when clicking on the image or a title/subtitle edit for the space, why would we allow to edit the description from an inline-button then?

I woudl say its less about consistency. more important is, that the most frequent actions are "in your face" and the less frequent get a backseat. editing the space description turned out to be less frequently used at least from what I see out there.

Copy link
Contributor

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kulmann kulmann merged commit 1ffbff2 into main Sep 18, 2025
28 checks passed
@kulmann kulmann deleted the remove-edit-space-description branch September 18, 2025 14:41
@openclouders openclouders mentioned this pull request Sep 18, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants