feat: add shift + mouse scroll for zoom out and zoom in in preview app #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndBear
force-pushed
the
img-zoom
branch
from
df0509f to
d452679
Compare
AlexAndBear
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds shift + mouse scroll functionality to zoom in and out in the preview app's image viewer. The changes simplify the image controls by removing position tracking and introducing a more straightforward zoom control mechanism.
- Replaces complex pan-zoom event handling with direct wheel event handling
- Implements shift + scroll wheel zoom functionality with 0.1 step increments
- Uses event bus pattern for image reset functionality instead of direct prop passing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| useImageControls.ts | Removes position tracking state and pan-zoom event handler, adds event bus for reset functionality |
| MediaImage.vue | Implements wheel event handler for shift+scroll zoom, replaces pan-zoom change events with direct zoom emission |
| App.vue | Updates component props to remove position tracking and use simplified zoom event handler |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AlexAndBear
commented
Sep 22, 2025
| :alt="file.name" | ||
| :data-id="file.id" | ||
| class="max-w-full max-h-full pt-4 cursor-move object-contain" | ||
| :style="`transform: rotate(${currentImageRotation}deg)`" |
Contributor
Author
There was a problem hiding this comment.
not needed anymore
AlexAndBear
commented
Sep 22, 2025
| :src="file.url" | ||
| :alt="file.name" | ||
| :data-id="file.id" | ||
| class="max-w-full max-h-full pt-4 cursor-move object-contain" |
Contributor
Author
There was a problem hiding this comment.
cursor-move object-contain are obsolete
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes