fix: sidebar versions loading (performance) #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
requested review from
AlexAndBear,
Copilot,
kulmann and
tammi-23
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the sidebar versions loading performance by preventing unnecessary re-fetching and re-rendering when resources haven't actually changed. The key improvement is to only load versions when the modification date (mdate) of the current resource has changed, rather than on every resource change.
- Only reload versions when the resource's mdate has changed, not on every resource selection
- Separate loading states for shares vs versions to avoid full sidebar re-renders
- Add loading indicator specifically for the file details section during version loading
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-pkg/src/components/SideBar/FileSideBar.vue | Implements mdate-based version loading optimization and separates loading states |
| packages/web-app-files/src/components/SideBar/Details/FileDetails.vue | Adds version-specific loading indicator to prevent full sidebar re-render |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kulmann
approved these changes
Oct 7, 2025
Previously, when the current resource had changed, the sidebar would re-fetch all versions, causing the entire sidebar to get re-rendered. I improved this in 2 ways: * only load versions if the mdate of the current resource has changed. * (re-)loading versions now only (re-)renders the file details list, no the entire sidebar.
JammingBen
force-pushed
the
fix/sidebar-versions-loading
branch
from
e11204d to
8289c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the current resource had changed, the sidebar would re-fetch all versions, causing the entire sidebar to get re-rendered.
I improved this in 2 ways:
fixes #1280