-
Notifications
You must be signed in to change notification settings - Fork 25
fix(admin-settings): space list and sidebar issues #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes missing space manager names in the sidebar for admin settings by adding a fallback mechanism when space member shares are not loaded.
- Adds fallback logic to retrieve manager information from space permissions when member shares are unavailable
- Imports
CollaboratorSharetype to support the permission-based manager detection - Updates the
ownerUsernamescomputed property to handle both shared members and permission-based scenarios
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/web-pkg/src/components/SideBar/Spaces/Details/SpaceDetails.vue
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/components/SideBar/Spaces/Details/SpaceDetails.vue
Outdated
Show resolved
Hide resolved
7fa8306 to
77b98f6
Compare
Fixes the broken space list after creating a space due to the missing permissions. Note that we currently can't fetch the permissions after creating a space because the server doesn't support `expand` on a drive GET request. Hence we fall back to a member count of 1 (always accurate directly after creating) and an empty list of manager names.
The remove types are wrong because they are not supported by the SDK.
77b98f6 to
7925b75
Compare
cd061ef to
7dc46c8
Compare
AlexAndBear
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expandon a drive GET request. Hence we fall back to a member count of 1 (always accurate directly after creating) and an empty list of manager names.fixes #1178
fixes #1251