Skip to content

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Sep 30, 2025

  • Adds missing space manager names in sidebar. We need to load the manager names via the permissions because we don't have the shares loaded in the admin settings.
  • Fixes the broken space list after creating a space due to the missing permissions. Note that we currently can't fetch the permissions after creating a space because the server doesn't support expand on a drive GET request. Hence we fall back to a member count of 1 (always accurate directly after creating) and an empty list of manager names.
  • plus a few small improvements and script setup refactor. Best reviewed via commits.

fixes #1178
fixes #1251

@JammingBen JammingBen self-assigned this Sep 30, 2025
Copilot AI review requested due to automatic review settings September 30, 2025 11:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes missing space manager names in the sidebar for admin settings by adding a fallback mechanism when space member shares are not loaded.

  • Adds fallback logic to retrieve manager information from space permissions when member shares are unavailable
  • Imports CollaboratorShare type to support the permission-based manager detection
  • Updates the ownerUsernames computed property to handle both shared members and permission-based scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen force-pushed the fix/missing-space-managers-sidebar branch 2 times, most recently from 7fa8306 to 77b98f6 Compare September 30, 2025 11:53
Fixes the broken space list after creating a space due to the missing permissions.

Note that we currently can't fetch the permissions after creating a space because the server doesn't support `expand` on a drive GET request. Hence we fall back to a member count of 1 (always accurate directly after creating) and an empty list of manager names.
The remove types are wrong because they are not supported by the SDK.
@JammingBen JammingBen force-pushed the fix/missing-space-managers-sidebar branch from 77b98f6 to 7925b75 Compare September 30, 2025 12:10
@JammingBen JammingBen changed the title fix(admin-settings): missing space manager names in sidebar fix(admin-settings): space list and sidebar issues Sep 30, 2025
@JammingBen JammingBen force-pushed the fix/missing-space-managers-sidebar branch from cd061ef to 7dc46c8 Compare September 30, 2025 12:28
@JammingBen JammingBen merged commit a875f40 into main Sep 30, 2025
28 checks passed
@JammingBen JammingBen deleted the fix/missing-space-managers-sidebar branch September 30, 2025 13:09
@openclouders openclouders mentioned this pull request Sep 30, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] UI Bug Spaces Space managers as missing in admin settings right sidebar

3 participants