fix: mobile tiles view right click menu #1345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes mobile context menu functionality in the tiles view by implementing proper mobile handling for right-click context menus. The fix ensures that on mobile devices, the context menu opens through the proper bottom drawer mechanism instead of the desktop positioned dropdown approach.
- Adds mobile detection and conditional logic to handle right-click context menus appropriately on mobile devices
- Updates action menu dropdown width from
w-autotow-3xsfor improved visual consistency - Updates corresponding test snapshots to reflect the width changes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ResourceTiles.vue | Adds mobile detection logic to redirect context menu handling to bottom drawer on mobile devices |
| ActionMenuDropItem.vue | Changes dropdown width from w-auto to w-3xs for consistent sizing |
| ContextActionMenu.spec.ts.snap | Updates test snapshots to reflect new dropdown width class |
| ActionMenuDropItem.spec.ts.snap | Updates test snapshots to reflect new dropdown width class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also increases the action menu sub-drop width a bit.
fixes #1335