fix(design-system): translate default modal action button labels #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes translation of default modal action button labels by replacing direct text references with computed properties that provide fallback translations.
- Replaces direct button text properties with computed properties that include default translations
- Adds
confirmLabelandcancelLabelcomputed properties with fallback$gettext()calls - Updates template to use the new computed properties instead of raw button text properties
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AlexAndBear
approved these changes
Oct 9, 2025
openclouders
pushed a commit
that referenced
this pull request
Oct 9, 2025
…abel-translation fix(design-system): translate default modal action button labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #740